fix(c++): replace deprecated std::aligned_storage#3793
Merged
Conversation
`std::aligned_storage` is marked as deprecated in c++23, replaced it with an aligned `std::byte` array. * `std::byte` is available since c++17 - the minimum supported version by fory. * `alignas` is available since c++11
RisinT96
force-pushed
the
fix-deprecated-warning
branch
from
408ce7e to
cfd3227
Compare
chaokunyang
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
std::aligned_storageis marked as deprecated in C++23, as can be seen in the following compilation warning:What does this PR do?
Replaces
std::aligned_storagewith astd::bytearray enclosed in an aligned struct.std::byteis available since C++17 - the minimum supported version by fory.alignasis available since C++11This change shouldn't break anything.
AI Contribution Checklist
Does this PR introduce any user-facing change?